Commit b7ff9efe authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: rx8111: demote warnings to debug level 



The proper way for userspace to react on a read time error is to have a
look at the voltage low information. There is no point in cluttering dmesg
as it is often not even visible to the end user.

Reviewed-by: default avatarWaqar Hameed <waqar.hameed@axis.com>
Link: https://lore.kernel.org/r/20240417191937.33790-1-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 6a216cba

drivers/rtc/rtc-rx8111.c

+5 −5
Original line number Diff line number Diff line
@@ -170,13 +170,13 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm) 
	}



	if (FIELD_GET(RX8111_FLAG_XST_BIT, regval)) {

		dev_warn(data->dev,

		dev_dbg(data->dev,

			"Crystal oscillation stopped, time is not reliable\n");

		return -EINVAL;

	}



	if (FIELD_GET(RX8111_FLAG_VLF_BIT, regval)) {

		dev_warn(data->dev,

		dev_dbg(data->dev,

			"Low voltage detected, time is not reliable\n");

		return -EINVAL;

	}
@@ -188,7 +188,7 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm) 
	}



	if (regval) {

		dev_warn(data->dev, "Clock stopped, time is not reliable\n");

		dev_dbg(data->dev, "Clock stopped, time is not reliable\n");

		return -EINVAL;

	}