Commit b7ffc98a authored by Shen Lichuan's avatar Shen Lichuan Committed by Dmitry Torokhov
Browse files

Input: wistron_btns - use kmemdup_array instead of kmemdup for multiple allocation 



Let the kmemdup_array() take care about multiplication
and possible overflows.

Using kmemdup_array() is more appropriate and makes the code
easier to audit.

Signed-off-by: default avatarShen Lichuan <shenlichuan@vivo.com>
Link: https://lore.kernel.org/r/20240826045253.3503-1-shenlichuan@vivo.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 6994d8b8

drivers/input/misc/wistron_btns.c

+2 −2
Original line number Diff line number Diff line
@@ -990,7 +990,7 @@ static int __init copy_keymap(void) 
	for (key = keymap; key->type != KE_END; key++)

		length++;



	new_keymap = kmemdup(keymap, length * sizeof(struct key_entry),

	new_keymap = kmemdup_array(keymap, length, sizeof(struct key_entry),

				   GFP_KERNEL);

	if (!new_keymap)

		return -ENOMEM;