Commit b833eb26 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski
Browse files

dt-bindings: pinctrl: samsung: add specific compatibles for existing SoC 



Samsung Exynos SoC reuses several devices from older designs, thus
historically we kept the old (block's) compatible only.  This works fine
and there is no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to each SoC in front of all old-SoC-like
compatibles.

Reviewed-by: default avatarAlim Akhtar <alim.akhtar@samsung.com>
Acked-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20231108104343.24192-6-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
parent b85ea95d

Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml

+15 −9
Original line number Diff line number Diff line
@@ -28,7 +28,8 @@ description: | 


properties:

  compatible:

    enum:

    oneOf:

      - enum:

          - samsung,s3c2410-wakeup-eint

          - samsung,s3c2412-wakeup-eint

          - samsung,s3c64xx-wakeup-eint
@@ -37,6 +38,11 @@ properties: 
          - samsung,exynos7-wakeup-eint

          - samsung,exynos850-wakeup-eint

          - samsung,exynosautov9-wakeup-eint

      - items:

          - enum:

              - samsung,exynos5433-wakeup-eint

              - samsung,exynos7885-wakeup-eint

          - const: samsung,exynos7-wakeup-eint



  interrupts:

    description:

Documentation/devicetree/bindings/pinctrl/samsung,pinctrl.yaml

+2 −1
Original line number Diff line number Diff line
@@ -313,7 +313,8 @@ examples: 
        pinctrl-0 = <&initial_alive>;



        wakeup-interrupt-controller {

            compatible = "samsung,exynos7-wakeup-eint";

            compatible = "samsung,exynos5433-wakeup-eint",

                         "samsung,exynos7-wakeup-eint";

            interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;

        };