Commit b83fd3e5 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Herbert Xu
Browse files

crypto: ccree - fix retry handling in cc_send_sync_request() 



If cc_queues_status() indicates that the queue is full,
cc_send_sync_request() should loop and retry.

However, cc_queues_status() returns either 0 (for success), or -ENOSPC
(for queue full), while cc_send_sync_request() checks for real errors by
comparing with -EAGAIN.  Hence -ENOSPC is always considered a real
error, and the code never retries the operation.

Fix this by just removing the check, as cc_queues_status() never returns
any other error value than -ENOSPC.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f5f7e1a0

drivers/crypto/ccree/cc_request_mgr.c

+0 −4
Original line number Diff line number Diff line
@@ -476,10 +476,6 @@ int cc_send_sync_request(struct cc_drvdata *drvdata, 
			break;



		spin_unlock_bh(&mgr->hw_lock);

		if (rc != -EAGAIN) {

			cc_pm_put_suspend(dev);

			return rc;

		}

		wait_for_completion_interruptible(&drvdata->hw_queue_avail);

		reinit_completion(&drvdata->hw_queue_avail);

	}