Commit b864ddb5 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: fix false alarm on invalid block address 

f2fs_ra_meta_pages can try to read ahead on invalid block address which is
not the corruption case.

Cc: <stable@kernel.org> # v6.9+
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218770


Fixes: 31f85ccc ("f2fs: unify the error handling of f2fs_is_valid_blkaddr")
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 2174035a

fs/f2fs/checkpoint.c

+5 −4
Original line number Diff line number Diff line
@@ -179,22 +179,22 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, 
		break;

	case META_SIT:

		if (unlikely(blkaddr >= SIT_BLK_CNT(sbi)))

			goto err;

			goto check_only;

		break;

	case META_SSA:

		if (unlikely(blkaddr >= MAIN_BLKADDR(sbi) ||

			blkaddr < SM_I(sbi)->ssa_blkaddr))

			goto err;

			goto check_only;

		break;

	case META_CP:

		if (unlikely(blkaddr >= SIT_I(sbi)->sit_base_addr ||

			blkaddr < __start_cp_addr(sbi)))

			goto err;

			goto check_only;

		break;

	case META_POR:

		if (unlikely(blkaddr >= MAX_BLKADDR(sbi) ||

			blkaddr < MAIN_BLKADDR(sbi)))

			goto err;

			goto check_only;

		break;

	case DATA_GENERIC:

	case DATA_GENERIC_ENHANCE:
@@ -228,6 +228,7 @@ static bool __f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi, 
	return true;

err:

	f2fs_handle_error(sbi, ERROR_INVALID_BLKADDR);

check_only:

	return false;

}