Unverified Commit b884e349 authored by Carlos Song's avatar Carlos Song Committed by Mark Brown
Browse files

spi: spi-fsl-lpspi: convert min_t() to simple min() 



Current min() has supported comparison by normal integer promotion rules,
so explicit type casts or min_t() are not needed.

Signed-off-by: default avatarCarlos Song <carlos.song@nxp.com>
Reviewed-by: default avatarDavid Laight <david.laight.linux@gmail.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20251210105001.3891776-1-carlos.song@nxp.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e6268db4

drivers/spi/spi-fsl-lpspi.c

+1 −9
Original line number Diff line number Diff line
@@ -486,15 +486,7 @@ static int fsl_lpspi_setup_transfer(struct spi_controller *controller, 
		fsl_lpspi->tx = fsl_lpspi_buf_tx_u32;

	}



	/*

	 * t->len is 'unsigned' and txfifosize and watermrk is 'u8', force

	 * type cast is inevitable. When len > 255, len will be truncated in min_t(),

	 * it caused wrong watermark set. 'unsigned int' is as the designated type

	 * for min_t() to avoid truncation.

	 */

	fsl_lpspi->watermark = min_t(unsigned int,

				     fsl_lpspi->txfifosize,

				     t->len);

	fsl_lpspi->watermark = min(fsl_lpspi->txfifosize, t->len);



	if (fsl_lpspi_can_dma(controller, spi, t))

		fsl_lpspi->usedma = true;