Commit b893d7ff authored by Mike Christie's avatar Mike Christie Committed by Martin K. Petersen
Browse files

scsi: core: Add passthrough tests for success and no failure definitions 



This patch adds scsi_check_passthrough() tests for the cases where a
command completes successfully and when the command failed but the caller
did not pass in a list of failures.

Signed-off-by: default avatarMike Christie <michael.christie@oracle.com>
Link: https://lore.kernel.org/r/20250113180757.16691-1-michael.christie@oracle.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7d6f88e7

drivers/scsi/scsi_lib_test.c

+7 −0
Original line number Diff line number Diff line
@@ -67,6 +67,13 @@ static void scsi_lib_test_multiple_sense(struct kunit *test) 
	};

	int i;



	/* Success */

	sc.result = 0;

	KUNIT_EXPECT_EQ(test, 0, scsi_check_passthrough(&sc, &failures));

	KUNIT_EXPECT_EQ(test, 0, scsi_check_passthrough(&sc, NULL));

	/* Command failed but caller did not pass in a failures array */

	scsi_build_sense(&sc, 0, ILLEGAL_REQUEST, 0x91, 0x36);

	KUNIT_EXPECT_EQ(test, 0, scsi_check_passthrough(&sc, NULL));

	/* Match end of array */

	scsi_build_sense(&sc, 0, ILLEGAL_REQUEST, 0x91, 0x36);

	KUNIT_EXPECT_EQ(test, -EAGAIN, scsi_check_passthrough(&sc, &failures));