Commit b89cd87b authored by Gal Pressman's avatar Gal Pressman Committed by Jakub Kicinski
Browse files

net/mlx5: Use %pe format specifier for error pointers 



Using the coccinelle test introduced in previous commit
(scripts/coccinelle/misc/ptr_err_to_pe.cocci), convert error logging
throughout the mlx5 driver to use the %pe format specifier instead of
PTR_ERR() with integer format specifiers.

Signed-off-by: default avatarGal Pressman <gal@nvidia.com>
Reviewed-by: default avatarAlexei Lazar <alazar@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/1758192227-701925-3-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 57c49d23

drivers/net/ethernet/mellanox/mlx5/core/diag/reporter_vnic.c

+2 −2
Original line number Diff line number Diff line
@@ -138,8 +138,8 @@ void mlx5_reporter_vnic_create(struct mlx5_core_dev *dev) 
					       dev);

	if (IS_ERR(health->vnic_reporter))

		mlx5_core_warn(dev,

			       "Failed to create vnic reporter, err = %ld\n",

			       PTR_ERR(health->vnic_reporter));

			       "Failed to create vnic reporter, err = %pe\n",

			       health->vnic_reporter);

}



void mlx5_reporter_vnic_destroy(struct mlx5_core_dev *dev)

drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c

+2 −2
Original line number Diff line number Diff line
@@ -138,8 +138,8 @@ void mlx5e_hv_vhca_stats_create(struct mlx5e_priv *priv) 
	if (IS_ERR_OR_NULL(agent)) {

		if (IS_ERR(agent))

			netdev_warn(priv->netdev,

				    "Failed to create hv vhca stats agent, err = %ld\n",

				    PTR_ERR(agent));

				    "Failed to create hv vhca stats agent, err = %pe\n",

				    agent);



		kvfree(priv->stats_agent.buf);

		return;

drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c

+4 −3
Original line number Diff line number Diff line
@@ -488,8 +488,8 @@ static int mlx5_esw_bridge_switchdev_event(struct notifier_block *nb, 
							       fdb_info,

							       br_offloads);

		if (IS_ERR(work)) {

			WARN_ONCE(1, "Failed to init switchdev work, err=%ld",

				  PTR_ERR(work));

			WARN_ONCE(1, "Failed to init switchdev work, err=%pe",

				  work);

			return notifier_from_errno(PTR_ERR(work));

		}
@@ -527,7 +527,8 @@ void mlx5e_rep_bridge_init(struct mlx5e_priv *priv) 
	br_offloads = mlx5_esw_bridge_init(esw);

	rtnl_unlock();

	if (IS_ERR(br_offloads)) {

		esw_warn(mdev, "Failed to init esw bridge (err=%ld)\n", PTR_ERR(br_offloads));

		esw_warn(mdev, "Failed to init esw bridge (err=%pe)\n",

			 br_offloads);

		return;

	}

drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c

+2 −2
Original line number Diff line number Diff line
@@ -672,8 +672,8 @@ void mlx5e_reporter_rx_create(struct mlx5e_priv *priv) 
						       &mlx5_rx_reporter_ops,

						       priv);

	if (IS_ERR(reporter)) {

		netdev_warn(priv->netdev, "Failed to create rx reporter, err = %ld\n",

			    PTR_ERR(reporter));

		netdev_warn(priv->netdev, "Failed to create rx reporter, err = %pe\n",

			    reporter);

		return;

	}

	priv->rx_reporter = reporter;

drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c

+2 −2
Original line number Diff line number Diff line
@@ -561,8 +561,8 @@ void mlx5e_reporter_tx_create(struct mlx5e_priv *priv) 
						       priv);

	if (IS_ERR(reporter)) {

		netdev_warn(priv->netdev,

			    "Failed to create tx reporter, err = %ld\n",

			    PTR_ERR(reporter));

			    "Failed to create tx reporter, err = %pe\n",

			    reporter);

		return;

	}

	priv->tx_reporter = reporter;