Commit b8bcc17f authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Jason A. Donenfeld
Browse files

wireguard: netlink: lower .maxattr for WG_CMD_GET_DEVICE 

Previously .maxattr was shared for both WG_CMD_GET_DEVICE and
WG_CMD_SET_DEVICE. Now that it is split, then we can lower it
for WG_CMD_GET_DEVICE to follow the documentation which defines
.maxattr as WGDEVICE_A_IFNAME for WG_CMD_GET_DEVICE.

$ grep -hC5 'one but not both of:' include/uapi/linux/wireguard.h
 * WG_CMD_GET_DEVICE
 * -----------------
 *
 * May only be called via NLM_F_REQUEST | NLM_F_DUMP. The command
 * should contain one but not both of:
 *
 *    WGDEVICE_A_IFINDEX: NLA_U32
 *    WGDEVICE_A_IFNAME: NLA_NUL_STRING, maxlen IFNAMSIZ - 1
 *
 * The kernel will then return several messages [...]

While other attributes weren't rejected previously, the consensus
is that nobody sends those attributes, so nothing should break.

Link: https://lore.kernel.org/r/aRyLoy2iqbkUipZW@zx2c4.com/


Suggested-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
parent 73af07d7

drivers/net/wireguard/netlink.c

+1 −1
Original line number Diff line number Diff line
@@ -623,7 +623,7 @@ static const struct genl_split_ops wireguard_nl_ops[] = { 
		.dumpit = wg_get_device_dump,

		.done = wg_get_device_done,

		.policy = device_policy,

		.maxattr = WGDEVICE_A_PEERS,

		.maxattr = WGDEVICE_A_IFNAME,

		.flags = GENL_UNS_ADMIN_PERM | GENL_CMD_CAP_DUMP,

	}, {

		.cmd = WG_CMD_SET_DEVICE,