Commit b8c8abef authored by Alexander Mikhalitsyn's avatar Alexander Mikhalitsyn Committed by Jakub Kicinski
Browse files

ipv4: correctly iterate over the target netns in inet_dump_ifaddr() 



A recent change to inet_dump_ifaddr had the function incorrectly iterate
over net rather than tgt_net, resulting in the data coming for the
incorrect network namespace.

Fixes: cdb2f80f ("inet: use xa_array iterator to implement inet_dump_ifaddr()")
Reported-by: default avatarStéphane Graber <stgraber@stgraber.org>
Closes: https://github.com/lxc/incus/issues/892


Bisected-by: default avatarStéphane Graber <stgraber@stgraber.org>
Signed-off-by: default avatarAlexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Tested-by: default avatarStéphane Graber <stgraber@stgraber.org>
Acked-by: default avatarChristian Brauner <brauner@kernel.org>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240528203030.10839-1-aleksandr.mikhalitsyn@canonical.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 92f1655a

net/ipv4/devinet.c

+1 −1
Original line number Diff line number Diff line
@@ -1903,7 +1903,7 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb) 


	cb->seq = inet_base_seq(tgt_net);



	for_each_netdev_dump(net, dev, ctx->ifindex) {

	for_each_netdev_dump(tgt_net, dev, ctx->ifindex) {

		in_dev = __in_dev_get_rcu(dev);

		if (!in_dev)

			continue;