Commit b8cdd253 authored by Al Viro's avatar Al Viro
Browse files

io_[gs]etxattr_prep(): just use getname() 



getname_flags(pathname, LOOKUP_FOLLOW) is obviously bogus - following
trailing symlinks has no impact on how to copy the pathname from userland...

Reviewed-by: default avatarChristian Brauner <brauner@kernel.org>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent dc7e76ba

io_uring/xattr.c

+2 −2
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ int io_getxattr_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) 


	path = u64_to_user_ptr(READ_ONCE(sqe->addr3));



	ix->filename = getname_flags(path, LOOKUP_FOLLOW);

	ix->filename = getname(path);

	if (IS_ERR(ix->filename)) {

		ret = PTR_ERR(ix->filename);

		ix->filename = NULL;
@@ -189,7 +189,7 @@ int io_setxattr_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) 


	path = u64_to_user_ptr(READ_ONCE(sqe->addr3));



	ix->filename = getname_flags(path, LOOKUP_FOLLOW);

	ix->filename = getname(path);

	if (IS_ERR(ix->filename)) {

		ret = PTR_ERR(ix->filename);

		ix->filename = NULL;