Commit b8ec0dc3 authored by Yunshui Jiang's avatar Yunshui Jiang Committed by Stefan Schmidt
Browse files

net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD() 



mac802154 devices update their dev->stats fields locklessly. Therefore
these counters should be updated atomically. Adopt SMP safe DEV_STATS_INC()
and DEV_STATS_ADD() to achieve this.

Signed-off-by: default avatarYunshui Jiang <jiangyunshui@kylinos.cn>
Message-ID: <20240531080739.2608969-1-jiangyunshui@kylinos.cn>
Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
parent 07aa3398

net/mac802154/tx.c

+4 −4
Original line number Diff line number Diff line
@@ -34,8 +34,8 @@ void ieee802154_xmit_sync_worker(struct work_struct *work) 
	if (res)

		goto err_tx;



	dev->stats.tx_packets++;

	dev->stats.tx_bytes += skb->len;

	DEV_STATS_INC(dev, tx_packets);

	DEV_STATS_ADD(dev, tx_bytes, skb->len);



	ieee802154_xmit_complete(&local->hw, skb, false);
@@ -90,8 +90,8 @@ ieee802154_tx(struct ieee802154_local *local, struct sk_buff *skb) 
		if (ret)

			goto err_wake_netif_queue;



		dev->stats.tx_packets++;

		dev->stats.tx_bytes += len;

		DEV_STATS_INC(dev, tx_packets);

		DEV_STATS_ADD(dev, tx_bytes, len);

	} else {

		local->tx_skb = skb;

		queue_work(local->workqueue, &local->sync_tx_work);