Commit b9049350 authored by David Howells's avatar David Howells
Browse files

afs: Fix missing/incorrect unlocking of RCU read lock 



In afs_proc_addr_prefs_show(), we need to unlock the RCU read lock in both
places before returning (and not lock it again).

Fixes: f94f70d3 ("afs: Provide a way to configure address priorities")
Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202401172243.cd53d5f6-oliver.sang@intel.com


Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
cc: linux-fsdevel@vger.kernel.org
parent cfcc005d

fs/afs/proc.c

+3 −2
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static int afs_proc_addr_prefs_show(struct seq_file *m, void *v) 


	if (!preflist) {

		seq_puts(m, "NO PREFS\n");

		return 0;

		goto out;

	}



	seq_printf(m, "PROT SUBNET                                      PRIOR (v=%u n=%u/%u/%u)\n",
@@ -191,7 +191,8 @@ static int afs_proc_addr_prefs_show(struct seq_file *m, void *v) 
		}

	}



	rcu_read_lock();

out:

	rcu_read_unlock();

	return 0;

}