Commit b92eb1ac authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Jakub Kicinski
Browse files

net: sparx5: flower: remove goto in sparx5_tc_flower_handler_control_usage() 



Remove goto, as it's only used once, and the error message is
specific to that context.

Only compile tested.

Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarDaniel Machon <daniel.machon@microchip.com>
Tested-by: default avatarDaniel Machon <daniel.machon@microchip.com>
Link: https://lore.kernel.org/r/20240424121632.459022-4-ast@fiberby.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8cd1b6c0

drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c

+4 −6
Original line number Diff line number Diff line
@@ -191,17 +191,15 @@ sparx5_tc_flower_handler_control_usage(struct vcap_tc_flower_parse_usage *st) 
		err = vcap_rule_add_key_u32(st->vrule,

					    VCAP_KF_L3_FRAGMENT_TYPE,

					    value, mask);

		if (err)

			goto out;

		if (err) {

			NL_SET_ERR_MSG_MOD(extack, "ip_frag parse error");

			return err;

		}

	}



	st->used_keys |= BIT_ULL(FLOW_DISSECTOR_KEY_CONTROL);



	return err;



out:

	NL_SET_ERR_MSG_MOD(extack, "ip_frag parse error");

	return err;

}



static int