Commit b94f11af authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Paolo Abeni
Browse files

net: wangxun: move PHYLINK dependency



The LIBWX library code is what calls into phylink, so any user of
it has to select CONFIG_PHYLINK at the moment, with NGBEVF missing this:

x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
wx_ethtool.c:(.text+0x613): undefined reference to `phylink_ethtool_nway_reset'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_link_ksettings':
wx_ethtool.c:(.text+0x62b): undefined reference to `phylink_ethtool_ksettings_get'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_link_ksettings':
wx_ethtool.c:(.text+0x643): undefined reference to `phylink_ethtool_ksettings_set'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_get_pauseparam':
wx_ethtool.c:(.text+0x65b): undefined reference to `phylink_ethtool_get_pauseparam'
x86_64-linux-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_set_pauseparam':
wx_ethtool.c:(.text+0x677): undefined reference to `phylink_ethtool_set_pauseparam'

Add the 'select PHYLINK' line in the libwx option directly so this will
always be enabled for all current and future wangxun drivers, and remove
the now duplicate lines.

Fixes: a0008a36 ("net: wangxun: add ngbevf build")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarVadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20251216213547.115026-1-arnd@kernel.org


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 472c5dd6
Loading
Loading
Loading
Loading
+1 −3
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ config LIBWX
	depends on PTP_1588_CLOCK_OPTIONAL
	select PAGE_POOL
	select DIMLIB
	select PHYLINK
	help
	Common library for Wangxun(R) Ethernet drivers.

@@ -29,7 +30,6 @@ config NGBE
	depends on PCI
	depends on PTP_1588_CLOCK_OPTIONAL
	select LIBWX
	select PHYLINK
	help
	  This driver supports Wangxun(R) GbE PCI Express family of
	  adapters.
@@ -48,7 +48,6 @@ config TXGBE
	depends on PTP_1588_CLOCK_OPTIONAL
	select MARVELL_10G_PHY
	select REGMAP
	select PHYLINK
	select HWMON if TXGBE=y
	select SFP
	select GPIOLIB
@@ -71,7 +70,6 @@ config TXGBEVF
	depends on PCI_MSI
	depends on PTP_1588_CLOCK_OPTIONAL
	select LIBWX
	select PHYLINK
	help
	  This driver supports virtual functions for SP1000A, WX1820AL,
	  WX5XXX, WX5XXXAL.