Commit b9580cf5 authored by Ovidiu Panait's avatar Ovidiu Panait Committed by Herbert Xu
Browse files

crypto: sun8i-ce-cipher - use pm_runtime_resume_and_get() 



Replace pm_runtime_get_sync() usage with pm_runtime_resume_and_get() to
simplify error handling.

This is recommended in the documentation of pm_runtime_get_sync():
/**
 * pm_runtime_get_sync - Bump up usage counter of a device and resume it.
...
 * Consider using pm_runtime_resume_and_get() instead of it, especially
 * if its return value is checked by the caller, as this is likely to result
 * in cleaner code.
...
 */

Signed-off-by: default avatarOvidiu Panait <ovidiu.panait.oss@gmail.com>
Tested-by: default avatarCorentin LABBE <clabbe.montjoie@gmail.com>
Acked-by: default avatarCorentin LABBE <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 031bc3e8

drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c

+1 −2
Original line number Diff line number Diff line
@@ -455,13 +455,12 @@ int sun8i_ce_cipher_init(struct crypto_tfm *tfm) 
		       crypto_skcipher_driver_name(op->fallback_tfm),

		       CRYPTO_MAX_ALG_NAME);



	err = pm_runtime_get_sync(op->ce->dev);

	err = pm_runtime_resume_and_get(op->ce->dev);

	if (err < 0)

		goto error_pm;



	return 0;

error_pm:

	pm_runtime_put_noidle(op->ce->dev);

	crypto_free_skcipher(op->fallback_tfm);

	return err;

}