Commit b99b2588 authored by Chao Yu's avatar Chao Yu Committed by Andrew Morton
Browse files

proc: remove mark_inode_dirty() in .setattr() 

procfs' .setattr() has updated i_uid, i_gid and i_mode into proc dirent,
we don't need to call mark_inode_dirty() for delayed update, remove it.

Link: https://lkml.kernel.org/r/20230131150840.34726-1-chao@kernel.org


Signed-off-by: default avatarChao Yu <chao@kernel.org>
Reviewed-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 0de15575

fs/proc/base.c

+0 −1
Original line number Diff line number Diff line
@@ -699,7 +699,6 @@ int proc_setattr(struct mnt_idmap *idmap, struct dentry *dentry, 
		return error;



	setattr_copy(&nop_mnt_idmap, inode, attr);

	mark_inode_dirty(inode);

	return 0;

}

fs/proc/generic.c

+0 −1
Original line number Diff line number Diff line
@@ -127,7 +127,6 @@ static int proc_notify_change(struct mnt_idmap *idmap, 
		return error;



	setattr_copy(&nop_mnt_idmap, inode, iattr);

	mark_inode_dirty(inode);



	proc_set_user(de, inode->i_uid, inode->i_gid);

	de->mode = inode->i_mode;

fs/proc/proc_sysctl.c

+0 −1
Original line number Diff line number Diff line
@@ -841,7 +841,6 @@ static int proc_sys_setattr(struct mnt_idmap *idmap, 
		return error;



	setattr_copy(&nop_mnt_idmap, inode, attr);

	mark_inode_dirty(inode);

	return 0;

}