Commit b9e63d6c authored by Ranjan Kumar's avatar Ranjan Kumar Committed by Martin K. Petersen
Browse files

scsi: mpi3mr: Validate SAS port assignments 



A sanity check on phy_mask was added in commit 3668651d ("scsi:
mpi3mr: Sanitise num_phys"). This causes warning messages when more than
64 phys are detected and devices connected to phys greater than 64 are
dropped.

The phy_mask bitmap is only needed for controller phys and not required
for expander phys. Controller phys can go up to a maximum of 64 and
therefore u64 is good enough to contain phy_mask bitmap.

To suppress those warnings and allow devices to be discovered as before
the offending commit, restrict the phy_mask setting and lowest phy
setting only to the controller phys.

Fixes: 3668651d ("scsi: mpi3mr: Sanitise num_phys")
Cc: stable@vger.kernel.org
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410051943.Mp9o5DlF-lkp@intel.com/


Reported-by: default avatarAlexander Motin <mav@ixsystems.com>
Signed-off-by: default avatarRanjan Kumar <ranjan.kumar@broadcom.com>
Link: https://lore.kernel.org/r/20241008074353.200379-1-ranjan.kumar@broadcom.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 19a198b6

drivers/scsi/mpi3mr/mpi3mr.h

+2 −2
Original line number Diff line number Diff line
@@ -542,8 +542,8 @@ struct mpi3mr_hba_port { 
 * @port_list: List of ports belonging to a SAS node

 * @num_phys: Number of phys associated with port

 * @marked_responding: used while refresing the sas ports

 * @lowest_phy: lowest phy ID of current sas port

 * @phy_mask: phy_mask of current sas port

 * @lowest_phy: lowest phy ID of current sas port, valid for controller port

 * @phy_mask: phy_mask of current sas port, valid for controller port

 * @hba_port: HBA port entry

 * @remote_identify: Attached device identification

 * @rphy: SAS transport layer rphy object

drivers/scsi/mpi3mr/mpi3mr_transport.c

+27 −15
Original line number Diff line number Diff line
@@ -590,12 +590,13 @@ static enum sas_linkrate mpi3mr_convert_phy_link_rate(u8 link_rate) 
 * @mrioc: Adapter instance reference

 * @mr_sas_port: Internal Port object

 * @mr_sas_phy: Internal Phy object

 * @host_node: Flag to indicate this is a host_node

 *

 * Return: None.

 */

static void mpi3mr_delete_sas_phy(struct mpi3mr_ioc *mrioc,

	struct mpi3mr_sas_port *mr_sas_port,

	struct mpi3mr_sas_phy *mr_sas_phy)

	struct mpi3mr_sas_phy *mr_sas_phy, u8 host_node)

{

	u64 sas_address = mr_sas_port->remote_identify.sas_address;
@@ -605,9 +606,13 @@ static void mpi3mr_delete_sas_phy(struct mpi3mr_ioc *mrioc, 


	list_del(&mr_sas_phy->port_siblings);

	mr_sas_port->num_phys--;



	if (host_node) {

		mr_sas_port->phy_mask &= ~(1 << mr_sas_phy->phy_id);



		if (mr_sas_port->lowest_phy == mr_sas_phy->phy_id)

			mr_sas_port->lowest_phy = ffs(mr_sas_port->phy_mask) - 1;

	}

	sas_port_delete_phy(mr_sas_port->port, mr_sas_phy->phy);

	mr_sas_phy->phy_belongs_to_port = 0;

}
@@ -617,12 +622,13 @@ static void mpi3mr_delete_sas_phy(struct mpi3mr_ioc *mrioc, 
 * @mrioc: Adapter instance reference

 * @mr_sas_port: Internal Port object

 * @mr_sas_phy: Internal Phy object

 * @host_node: Flag to indicate this is a host_node

 *

 * Return: None.

 */

static void mpi3mr_add_sas_phy(struct mpi3mr_ioc *mrioc,

	struct mpi3mr_sas_port *mr_sas_port,

	struct mpi3mr_sas_phy *mr_sas_phy)

	struct mpi3mr_sas_phy *mr_sas_phy, u8 host_node)

{

	u64 sas_address = mr_sas_port->remote_identify.sas_address;
@@ -632,9 +638,12 @@ static void mpi3mr_add_sas_phy(struct mpi3mr_ioc *mrioc, 


	list_add_tail(&mr_sas_phy->port_siblings, &mr_sas_port->phy_list);

	mr_sas_port->num_phys++;

	if (host_node) {

		mr_sas_port->phy_mask |= (1 << mr_sas_phy->phy_id);



		if (mr_sas_phy->phy_id < mr_sas_port->lowest_phy)

			mr_sas_port->lowest_phy = ffs(mr_sas_port->phy_mask) - 1;

	}

	sas_port_add_phy(mr_sas_port->port, mr_sas_phy->phy);

	mr_sas_phy->phy_belongs_to_port = 1;

}
@@ -675,7 +684,7 @@ static void mpi3mr_add_phy_to_an_existing_port(struct mpi3mr_ioc *mrioc, 
			if (srch_phy == mr_sas_phy)

				return;

		}

		mpi3mr_add_sas_phy(mrioc, mr_sas_port, mr_sas_phy);

		mpi3mr_add_sas_phy(mrioc, mr_sas_port, mr_sas_phy, mr_sas_node->host_node);

		return;

	}

}
@@ -736,7 +745,7 @@ static void mpi3mr_del_phy_from_an_existing_port(struct mpi3mr_ioc *mrioc, 
				mpi3mr_delete_sas_port(mrioc, mr_sas_port);

			else

				mpi3mr_delete_sas_phy(mrioc, mr_sas_port,

				    mr_sas_phy);

				    mr_sas_phy, mr_sas_node->host_node);

			return;

		}

	}
@@ -1028,7 +1037,7 @@ mpi3mr_alloc_hba_port(struct mpi3mr_ioc *mrioc, u16 port_id) 
/**

 * mpi3mr_get_hba_port_by_id - find hba port by id

 * @mrioc: Adapter instance reference

 * @port_id - Port ID to search

 * @port_id: Port ID to search

 *

 * Return: mpi3mr_hba_port reference for the matched port

 */
@@ -1367,7 +1376,8 @@ static struct mpi3mr_sas_port *mpi3mr_sas_port_add(struct mpi3mr_ioc *mrioc, 
	mpi3mr_sas_port_sanity_check(mrioc, mr_sas_node,

	    mr_sas_port->remote_identify.sas_address, hba_port);



	if (mr_sas_node->num_phys >= sizeof(mr_sas_port->phy_mask) * 8)

	if (mr_sas_node->host_node && mr_sas_node->num_phys >=

			sizeof(mr_sas_port->phy_mask) * 8)

		ioc_info(mrioc, "max port count %u could be too high\n",

		    mr_sas_node->num_phys);
@@ -1377,7 +1387,7 @@ static struct mpi3mr_sas_port *mpi3mr_sas_port_add(struct mpi3mr_ioc *mrioc, 
		    (mr_sas_node->phy[i].hba_port != hba_port))

			continue;



		if (i >= sizeof(mr_sas_port->phy_mask) * 8) {

		if (mr_sas_node->host_node && (i >= sizeof(mr_sas_port->phy_mask) * 8)) {

			ioc_warn(mrioc, "skipping port %u, max allowed value is %zu\n",

			    i, sizeof(mr_sas_port->phy_mask) * 8);

			goto out_fail;
@@ -1385,6 +1395,7 @@ static struct mpi3mr_sas_port *mpi3mr_sas_port_add(struct mpi3mr_ioc *mrioc, 
		list_add_tail(&mr_sas_node->phy[i].port_siblings,

		    &mr_sas_port->phy_list);

		mr_sas_port->num_phys++;

		if (mr_sas_node->host_node)

			mr_sas_port->phy_mask |= (1 << i);

	}
@@ -1394,6 +1405,7 @@ static struct mpi3mr_sas_port *mpi3mr_sas_port_add(struct mpi3mr_ioc *mrioc, 
		goto out_fail;

	}



	if (mr_sas_node->host_node)

		mr_sas_port->lowest_phy = ffs(mr_sas_port->phy_mask) - 1;



	if (mr_sas_port->remote_identify.device_type == SAS_END_DEVICE) {