Commit ba27e9d2 authored by Siddharth Vadapalli's avatar Siddharth Vadapalli Committed by Vinod Koul
Browse files

dmaengine: ti: k3-udma-glue: Fix of_k3_udma_glue_parse_chn_by_id() 



The of_k3_udma_glue_parse_chn_by_id() helper function erroneously
invokes "of_node_put()" on the "udmax_np" device-node passed to it,
without having incremented its reference count at any point. Fix it.

Fixes: 81a1f90f ("dmaengine: ti: k3-udma-glue: Add function to parse channel by ID")
Signed-off-by: default avatarSiddharth Vadapalli <s-vadapalli@ti.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
Acked-by: default avatarPeter <Ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20240602013319.2975894-1-s-vadapalli@ti.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent e3215dec

drivers/dma/ti/k3-udma-glue.c

+1 −4
Original line number Diff line number Diff line
@@ -200,12 +200,9 @@ of_k3_udma_glue_parse_chn_by_id(struct device_node *udmax_np, struct k3_udma_glu 


	ret = of_k3_udma_glue_parse(udmax_np, common);

	if (ret)

		goto out_put_spec;

		return ret;



	ret = of_k3_udma_glue_parse_chn_common(common, thread_id, tx_chn);



out_put_spec:

	of_node_put(udmax_np);

	return ret;

}