Commit ba4fb3b3 authored by Zhu Jun's avatar Zhu Jun Committed by Andrii Nakryiko
Browse files

selftests/bpf: Removed redundant fd after close in bpf_prog_load_log_buf 



Removed unnecessary `fd = -1` assignments after closing file descriptors.
because it will be assigned by the function bpf_prog_load().This improves
code readability and removes redundant operations.

Signed-off-by: default avatarZhu Jun <zhujun2@cmss.chinamobile.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20241010055737.4292-1-zhujun2@cmss.chinamobile.com
parent f3ef5317

tools/testing/selftests/bpf/prog_tests/log_buf.c

+0 −3
Original line number Diff line number Diff line
@@ -169,7 +169,6 @@ static void bpf_prog_load_log_buf(void) 
	ASSERT_GE(fd, 0, "good_fd1");

	if (fd >= 0)

		close(fd);

	fd = -1;



	/* log_level == 2 should always fill log_buf, even for good prog */

	log_buf[0] = '\0';
@@ -180,7 +179,6 @@ static void bpf_prog_load_log_buf(void) 
	ASSERT_GE(fd, 0, "good_fd2");

	if (fd >= 0)

		close(fd);

	fd = -1;



	/* log_level == 0 should fill log_buf for bad prog */

	log_buf[0] = '\0';
@@ -191,7 +189,6 @@ static void bpf_prog_load_log_buf(void) 
	ASSERT_LT(fd, 0, "bad_fd");

	if (fd >= 0)

		close(fd);

	fd = -1;



	free(log_buf);

}