Commit ba54b1a2 authored by Sasha Neftin's avatar Sasha Neftin Committed by Tony Nguyen
Browse files

intel: legacy: Partial revert of field get conversion 



Refactoring of the field get conversion introduced a regression in the
legacy Wake On Lan from a magic packet with i219 devices. Rx address
copied not correctly from MAC to PHY with FIELD_GET macro.

Fixes: b9a45254 ("intel: legacy: field get conversion")
Suggested-by: default avatarVitaly Lifshits <vitaly.lifshits@intel.com>
Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
Tested-by: default avatarNaama Meir <naamax.meir@linux.intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent ef27f655

drivers/net/ethernet/intel/e1000e/ich8lan.c

+1 −1
Original line number Diff line number Diff line
@@ -2559,7 +2559,7 @@ void e1000_copy_rx_addrs_to_phy_ich8lan(struct e1000_hw *hw) 
		hw->phy.ops.write_reg_page(hw, BM_RAR_H(i),

					   (u16)(mac_reg & 0xFFFF));

		hw->phy.ops.write_reg_page(hw, BM_RAR_CTRL(i),

					   FIELD_GET(E1000_RAH_AV, mac_reg));

					   (u16)((mac_reg & E1000_RAH_AV) >> 16));

	}



	e1000_disable_phy_wakeup_reg_access_bm(hw, &phy_reg);