Commit ba635374 authored Aug 22, 2024 by Stuart Hayes Committed by Greg Kroah-Hartman Sep 03, 2024

driver core: don't always lock parent in shutdown



Don't lock a parent device unless it is needed in device_shutdown. This
is in preparation for making device shutdown asynchronous, when it will
be needed to allow children of a common parent to shut down
simultaneously.

Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
Signed-off-by: David Jeffery <djeffery@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Tested-by: Keith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20240822202805.6379-2-stuart.w.hayes@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 24e041e1

drivers/base/core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4816,7 +4816,7 @@ void device_shutdown(void)
		spin_unlock(&devices_kset->list_lock);

		/* hold lock to avoid race with probe/release */
		if (parent)
		if (parent && dev->bus && dev->bus->need_parent_lock)
		device_lock(parent);
		device_lock(dev);

		@@ -4840,7 +4840,7 @@ void device_shutdown(void)
		}

		device_unlock(dev);
		if (parent)
		if (parent && dev->bus && dev->bus->need_parent_lock)
		device_unlock(parent);

		put_device(dev);