Commit bab5d988 authored Sep 07, 2018 by Igor Stoppa Committed by Mike Snitzer Oct 16, 2018

dm: remove unnecessary unlikely() around WARN_ON_ONCE()



WARN_ON() already contains an unlikely(), so it's not necessary to
wrap it into another.

Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent 092b5648

drivers/md/dm-cache-policy-smq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1200,7 +1200,7 @@ static void queue_demotion(struct smq_policy *mq)
		struct policy_work work;
		struct entry *e;

		if (unlikely(WARN_ON_ONCE(!mq->migrations_allowed)))
		if (WARN_ON_ONCE(!mq->migrations_allowed))
		return;

		e = q_peek(&mq->clean, mq->clean.nr_levels / 2, true);

drivers/md/dm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1666,7 +1666,7 @@ static blk_qc_t __process_bio(struct mapped_device *md,
		* Defend against IO still getting in during teardown
		* - as was seen for a time with nvme-fcloop
		*/
		if (unlikely(WARN_ON_ONCE(!ti \|\| !dm_target_is_valid(ti)))) {
		if (WARN_ON_ONCE(!ti \|\| !dm_target_is_valid(ti))) {
		error = -EIO;
		goto out;
		}