Commit babfeb9c authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: nct3018y: fix possible NULL dereference 



alarm_enable and alarm_flag are allowed to be NULL but will be dereferenced
later by the dev_dbg call.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202305180042.DEzW1pSd-lkp@intel.com/
Link: https://lore.kernel.org/r/20240229222127.1878176-1-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent c12e67e0

drivers/rtc/rtc-nct3018y.c

+3 −3
Original line number Diff line number Diff line
@@ -102,6 +102,8 @@ static int nct3018y_get_alarm_mode(struct i2c_client *client, unsigned char *ala 
		if (flags < 0)

			return flags;

		*alarm_enable = flags & NCT3018Y_BIT_AIE;

		dev_dbg(&client->dev, "%s:alarm_enable:%x\n", __func__, *alarm_enable);



	}



	if (alarm_flag) {
@@ -110,11 +112,9 @@ static int nct3018y_get_alarm_mode(struct i2c_client *client, unsigned char *ala 
		if (flags < 0)

			return flags;

		*alarm_flag = flags & NCT3018Y_BIT_AF;

		dev_dbg(&client->dev, "%s:alarm_flag:%x\n", __func__, *alarm_flag);

	}



	dev_dbg(&client->dev, "%s:alarm_enable:%x alarm_flag:%x\n",

		__func__, *alarm_enable, *alarm_flag);



	return 0;

}