Commit badff5fe authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915/fbdev: Use fb->normal_view.gtt 



Grab the GTT view for the fbdev fb pinning from
fb->normal_view.gtt instead of having and extra one on
the stack. Seems safer in case we ever put any new
information into normal GTT views.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250122151755.6928-6-ville.syrjala@linux.intel.com


Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
parent 4d291c44

drivers/gpu/drm/i915/display/intel_fbdev.c

+1 −4
Original line number Diff line number Diff line
@@ -177,9 +177,6 @@ static int intelfb_create(struct drm_fb_helper *helper, 
	struct intel_framebuffer *fb = ifbdev->fb;

	struct drm_device *dev = helper->dev;

	struct drm_i915_private *dev_priv = to_i915(dev);

	const struct i915_gtt_view view = {

		.type = I915_GTT_VIEW_NORMAL,

	};

	intel_wakeref_t wakeref;

	struct fb_info *info;

	struct i915_vma *vma;
@@ -226,7 +223,7 @@ static int intelfb_create(struct drm_fb_helper *helper, 
	 * This also validates that any existing fb inherited from the

	 * BIOS is suitable for own access.

	 */

	vma = intel_fb_pin_to_ggtt(&fb->base, &view,

	vma = intel_fb_pin_to_ggtt(&fb->base, &fb->normal_view.gtt,

				   fb->min_alignment, 0,

				   intel_fb_view_vtd_guard(&fb->base, &fb->normal_view,

							   DRM_MODE_ROTATE_0),