Commit bafffd56 authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Thomas Gleixner
Browse files

clocksource: Remove unused clocksource_change_rating 



clocksource_change_rating() has been unused since 2017's commit
63ed4e0c ("Drivers: hv: vmbus: Consolidate all Hyper-V specific clocksource code")

Remove it.

__clocksource_change_rating now only has one use which is ifdef'd.
Move it into the ifdef'd section.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241010135446.213098-1-linux@treblig.org
parent b7f6d3a0

include/linux/clocksource.h

+0 −1
Original line number Diff line number Diff line
@@ -215,7 +215,6 @@ static inline s64 clocksource_cyc2ns(u64 cycles, u32 mult, u32 shift) 


extern int clocksource_unregister(struct clocksource*);

extern void clocksource_touch_watchdog(void);

extern void clocksource_change_rating(struct clocksource *cs, int rating);

extern void clocksource_suspend(void);

extern void clocksource_resume(void);

extern struct clocksource * __init clocksource_default_clock(void);

kernel/time/clocksource.c

+10 −30
Original line number Diff line number Diff line
@@ -20,6 +20,8 @@ 
#include "tick-internal.h"

#include "timekeeping_internal.h"



static void clocksource_enqueue(struct clocksource *cs);



static noinline u64 cycles_to_nsec_safe(struct clocksource *cs, u64 start, u64 end)

{

	u64 delta = clocksource_delta(end, start, cs->mask);
@@ -171,7 +173,6 @@ static inline void clocksource_watchdog_unlock(unsigned long *flags) 
}



static int clocksource_watchdog_kthread(void *data);

static void __clocksource_change_rating(struct clocksource *cs, int rating);



static void clocksource_watchdog_work(struct work_struct *work)

{
@@ -191,6 +192,13 @@ static void clocksource_watchdog_work(struct work_struct *work) 
	kthread_run(clocksource_watchdog_kthread, NULL, "kwatchdog");

}



static void clocksource_change_rating(struct clocksource *cs, int rating)

{

	list_del(&cs->list);

	cs->rating = rating;

	clocksource_enqueue(cs);

}



static void __clocksource_unstable(struct clocksource *cs)

{

	cs->flags &= ~(CLOCK_SOURCE_VALID_FOR_HRES | CLOCK_SOURCE_WATCHDOG);
@@ -697,7 +705,7 @@ static int __clocksource_watchdog_kthread(void) 
	list_for_each_entry_safe(cs, tmp, &watchdog_list, wd_list) {

		if (cs->flags & CLOCK_SOURCE_UNSTABLE) {

			list_del_init(&cs->wd_list);

			__clocksource_change_rating(cs, 0);

			clocksource_change_rating(cs, 0);

			select = 1;

		}

		if (cs->flags & CLOCK_SOURCE_RESELECT) {
@@ -1255,34 +1263,6 @@ int __clocksource_register_scale(struct clocksource *cs, u32 scale, u32 freq) 
}

EXPORT_SYMBOL_GPL(__clocksource_register_scale);



static void __clocksource_change_rating(struct clocksource *cs, int rating)

{

	list_del(&cs->list);

	cs->rating = rating;

	clocksource_enqueue(cs);

}



/**

 * clocksource_change_rating - Change the rating of a registered clocksource

 * @cs:		clocksource to be changed

 * @rating:	new rating

 */

void clocksource_change_rating(struct clocksource *cs, int rating)

{

	unsigned long flags;



	mutex_lock(&clocksource_mutex);

	clocksource_watchdog_lock(&flags);

	__clocksource_change_rating(cs, rating);

	clocksource_watchdog_unlock(&flags);



	clocksource_select();

	clocksource_select_watchdog(false);

	clocksource_suspend_select(false);

	mutex_unlock(&clocksource_mutex);

}

EXPORT_SYMBOL(clocksource_change_rating);



/*

 * Unbind clocksource @cs. Called with clocksource_mutex held

 */