Commit bb120ad5 authored by Alexey Nepomnyashih's avatar Alexey Nepomnyashih Committed by Takashi Iwai
Browse files

ALSA: firewire-lib: fix uninitialized local variable 



Similar to commit d8dc8720 ("ALSA: firewire-lib: fix uninitialized
local variable"), the local variable `curr_cycle_time` in
process_rx_packets() is declared without initialization.

When the tracepoint event is not probed, the variable may appear to be
used without being initialized. In practice the value is only relevant
when the tracepoint is enabled, however initializing it avoids potential
use of an uninitialized value and improves code safety.

Initialize `curr_cycle_time` to zero.

Fixes: fef4e61b ("ALSA: firewire-lib: extend tracepoints event including CYCLE_TIME of 1394 OHCI")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAlexey Nepomnyashih <sdl@nppct.ru>
Link: https://patch.msgid.link/20260316191824.83249-1-sdl@nppct.ru


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0bdf27ab

sound/firewire/amdtp-stream.c

+1 −1
Original line number Diff line number Diff line
@@ -1164,7 +1164,7 @@ static void process_rx_packets(struct fw_iso_context *context, u32 tstamp, size_ 
	struct pkt_desc *desc = s->packet_descs_cursor;

	unsigned int pkt_header_length;

	unsigned int packets;

	u32 curr_cycle_time;

	u32 curr_cycle_time = 0;

	bool need_hw_irq;

	int i;