Commit bb2243f4 authored by Hou Tao's avatar Hou Tao Committed by Alexei Starovoitov
Browse files

bpf: Check map->record at the beginning of check_and_free_fields() 



When there are no special fields in the map value, there is no need to
invoke bpf_obj_free_fields(). Therefore, checking the validity of
map->record in advance.

After the change, the benchmark result of the per-cpu update case in
map_perf_test increased by 40% under a 16-CPU VM.

Signed-off-by: default avatarHou Tao <houtao1@huawei.com>
Acked-by: default avatarKumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20250315150930.1511727-1-houtao@huaweicloud.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent 8c10109a

kernel/bpf/hashtab.c

+3 −0
Original line number Diff line number Diff line
@@ -787,6 +787,9 @@ static int htab_lru_map_gen_lookup(struct bpf_map *map, 
static void check_and_free_fields(struct bpf_htab *htab,

				  struct htab_elem *elem)

{

	if (IS_ERR_OR_NULL(htab->map.record))

		return;



	if (htab_is_percpu(htab)) {

		void __percpu *pptr = htab_elem_get_ptr(elem, htab->map.key_size);

		int cpu;