Commit bb622439 authored by Josh Poimboeuf's avatar Josh Poimboeuf Committed by Peter Zijlstra
Browse files

objtool: Add --Werror option 



Any objtool warning has the potential of reflecting (or triggering) a
major bug in the kernel or compiler which could result in crashing the
kernel or breaking the livepatch consistency model.

In preparation for failing the build on objtool errors/warnings, add a
new --Werror option.

[ jpoimboe: commit log, comments, error out on fatal errors too ]

Co-developed-by: default avatarBrendan Jackman <jackmanb@google.com>
Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/e423ea4ec297f510a108aa6c78b52b9fe30fa8c1.1741975349.git.jpoimboe@kernel.org
parent 5a406031

tools/objtool/builtin-check.c

+1 −0
Original line number Diff line number Diff line
@@ -101,6 +101,7 @@ static const struct option check_options[] = { 
	OPT_BOOLEAN(0,   "sec-address", &opts.sec_address, "print section addresses in warnings"),

	OPT_BOOLEAN(0,   "stats", &opts.stats, "print statistics"),

	OPT_BOOLEAN('v', "verbose", &opts.verbose, "verbose warnings"),

	OPT_BOOLEAN(0,   "Werror", &opts.werror, "return error on warnings"),



	OPT_END(),

};

tools/objtool/check.c

+12 −3
Original line number Diff line number Diff line
@@ -4756,9 +4756,18 @@ int check(struct objtool_file *file) 


out:

	/*

	 *  For now, don't fail the kernel build on fatal warnings.  These

	 *  errors are still fairly common due to the growing matrix of

	 *  supported toolchains and their recent pace of change.

	 * CONFIG_OBJTOOL_WERROR upgrades all warnings (and errors) to actual

	 * errors.

	 *

	 * Note that even "fatal" type errors don't actually return an error

	 * without CONFIG_OBJTOOL_WERROR.  That probably needs improved at some

	 * point.

	 */

	if (opts.werror && (ret || warnings)) {

		if (warnings)

			WARN("%d warning(s) upgraded to errors", warnings);

		return 1;

	}



	return 0;

}

tools/objtool/include/objtool/builtin.h

+1 −0
Original line number Diff line number Diff line
@@ -39,6 +39,7 @@ struct opts { 
	bool sec_address;

	bool stats;

	bool verbose;

	bool werror;

};



extern struct opts opts;