Commit bb664e50 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Rafael J. Wysocki
Browse files

ACPI: sysfs: remove return value of acpi_device_setup_files() 



The function can not fail anymore, so drop its return value.

Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20240709-acpi-sysfs-groups-v2-5-058ab0667fa8@weissschuh.net


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent cd488472

drivers/acpi/device_sysfs.c

+1 −5
Original line number Diff line number Diff line
@@ -605,13 +605,9 @@ const struct attribute_group *acpi_groups[] = { 
 * acpi_device_setup_files - Create sysfs attributes of an ACPI device.

 * @dev: ACPI device object.

 */

int acpi_device_setup_files(struct acpi_device *dev)

void acpi_device_setup_files(struct acpi_device *dev)

{

	int result = 0;



	acpi_expose_nondev_subnodes(&dev->dev.kobj, &dev->data);



	return result;

}



/**

drivers/acpi/internal.h

+1 −1
Original line number Diff line number Diff line
@@ -118,7 +118,7 @@ void acpi_init_device_object(struct acpi_device *device, acpi_handle handle, 
			     int type, void (*release)(struct device *));

int acpi_tie_acpi_dev(struct acpi_device *adev);

int acpi_device_add(struct acpi_device *device);

int acpi_device_setup_files(struct acpi_device *dev);

void acpi_device_setup_files(struct acpi_device *dev);

void acpi_device_remove_files(struct acpi_device *dev);

extern const struct attribute_group *acpi_groups[];

void acpi_device_add_finalize(struct acpi_device *device);

drivers/acpi/scan.c

+1 −4
Original line number Diff line number Diff line
@@ -795,10 +795,7 @@ int acpi_device_add(struct acpi_device *device) 
		goto err;

	}



	result = acpi_device_setup_files(device);

	if (result)

		pr_err("Error creating sysfs interface for device %s\n",

		       dev_name(&device->dev));

	acpi_device_setup_files(device);



	return 0;