Commit bb68e018 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: visconti: use PHY_INTF_SEL_x to select PHY interface 



Convert dwmac-visconti to use the PHY_INTF_SEL_x definitions. The
original definitions used constant 0, BIT(0) (==1) and BIT(2) (==4)
to define these, but the values of the bits corresponds with the
PHY_INTF_SEL_x values, so it is highly likely that these are not
individual bits, but the PHY_INTF_SEL_x bitfield.

This removes this incorrect use of BIT().

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1vIjUZ-0000000Dqu5-2sDI@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 45c5e24a

drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c

+3 −3
Original line number Diff line number Diff line
@@ -42,9 +42,9 @@ 


#define ETHER_CLK_SEL_RX_TX_CLK_EN (ETHER_CLK_SEL_RX_CLK_EN | ETHER_CLK_SEL_TX_CLK_EN)



#define ETHER_CONFIG_INTF_MII 0

#define ETHER_CONFIG_INTF_RGMII BIT(0)

#define ETHER_CONFIG_INTF_RMII BIT(2)

#define ETHER_CONFIG_INTF_MII	PHY_INTF_SEL_GMII_MII

#define ETHER_CONFIG_INTF_RGMII	PHY_INTF_SEL_RGMII

#define ETHER_CONFIG_INTF_RMII	PHY_INTF_SEL_RMII



struct visconti_eth {

	void __iomem *reg;