Commit bb7663de authored by Daniel Lee's avatar Daniel Lee Committed by Martin K. Petersen
Browse files

scsi: ufs: sysfs: Make HID attributes visible 



Call sysfs_update_group() after reading the device descriptor to ensure
the HID sysfs attributes are visible when the feature is supported.

Fixes: ae7795a8 ("scsi: ufs: core: Add HID support")
Signed-off-by: default avatarDaniel Lee <chullee@google.com>
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 60cd16a3

drivers/ufs/core/ufs-sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -1949,7 +1949,7 @@ static umode_t ufs_sysfs_hid_is_visible(struct kobject *kobj, 
	return	hba->dev_info.hid_sup ? attr->mode : 0;

}



static const struct attribute_group ufs_sysfs_hid_group = {

const struct attribute_group ufs_sysfs_hid_group = {

	.name = "hid",

	.attrs = ufs_sysfs_hid,

	.is_visible = ufs_sysfs_hid_is_visible,

drivers/ufs/core/ufs-sysfs.h

+1 −0
Original line number Diff line number Diff line
@@ -14,5 +14,6 @@ void ufs_sysfs_remove_nodes(struct device *dev); 


extern const struct attribute_group ufs_sysfs_unit_descriptor_group;

extern const struct attribute_group ufs_sysfs_lun_attributes_group;

extern const struct attribute_group ufs_sysfs_hid_group;



#endif

drivers/ufs/core/ufshcd.c

+2 −0
Original line number Diff line number Diff line
@@ -8480,6 +8480,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba) 
				DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP) &

				UFS_DEV_HID_SUPPORT;



	sysfs_update_group(&hba->dev->kobj, &ufs_sysfs_hid_group);



	model_index = desc_buf[DEVICE_DESC_PARAM_PRDCT_NAME];



	err = ufshcd_read_string_desc(hba, model_index,