Commit bba20b89 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Martin K. Petersen
Browse files

scsi: scsi_debug: Remove a useless memset() 



'arr' is kzalloc()'ed, so there is no need to call memset(.., 0, ...) on
it. It is already cleared.

This is a follow up of commit b952eb27 ("scsi: scsi_debug: Allocate the
MODE SENSE response from the heap").

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/6296722174e39a51cac74b7fc68b0d75bd0db2a3.1725690433.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4708c933

drivers/scsi/scsi_debug.c

+0 −1
Original line number Diff line number Diff line
@@ -2760,7 +2760,6 @@ static int resp_mode_sense(struct scsi_cmnd *scp, 
	else

		bd_len = 0;

	alloc_len = msense_6 ? cmd[4] : get_unaligned_be16(cmd + 7);

	memset(arr, 0, SDEBUG_MAX_MSENSE_SZ);

	if (0x3 == pcontrol) {  /* Saving values not supported */

		mk_sense_buffer(scp, ILLEGAL_REQUEST, SAVING_PARAMS_UNSUP, 0);

		return check_condition_result;