Commit bbc31108 authored by Dan Carpenter's avatar Dan Carpenter Committed by Ulf Hansson
Browse files

pmdomain: thead: Fix error pointer vs NULL bug in th1520_pd_reboot_init() 



The devm_auxiliary_device_create() returns NULL on error.  It never
returns error pointers.  Using PTR_ERR_OR_ZERO() here means the function
always returns success.  Replace the PTR_ERR_OR_ZERO() call check with
a NULL check.

Fixes: 64581f41 ("pmdomain: thead: create auxiliary device for rebooting")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Acked-by: default avatarIcenowy Zheng <uwu@icenowy.me>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent de023206

drivers/pmdomain/thead/th1520-pm-domains.c

+3 −1
Original line number Diff line number Diff line
@@ -179,8 +179,10 @@ static int th1520_pd_reboot_init(struct device *dev, 
	struct auxiliary_device *adev;



	adev = devm_auxiliary_device_create(dev, "reboot", aon_chan);

	if (!adev)

		return -ENODEV;



	return PTR_ERR_OR_ZERO(adev);

	return 0;

}



static int th1520_pd_probe(struct platform_device *pdev)