Commit bc089c47 authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt (Google)
Browse files

tracing: Convert function graph set_flags() to use a switch() statement 

Currently the set_flags() of the function graph tracer has a bunch of:

  if (bit == FLAG1) {
	[..]
  }

  if (bit == FLAG2) {
	[..]
  }

To clean it up a bit, convert it over to a switch statement.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: https://patch.msgid.link/20251114192319.117123664@kernel.org


Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 5abb6ccb

kernel/trace/trace_functions_graph.c

+7 −5
Original line number Diff line number Diff line
@@ -1664,7 +1664,8 @@ func_graph_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set) 
	if (!!set == !!(tr->current_trace_flags->val & bit))

		return 0;



	if (bit == TRACE_GRAPH_SLEEP_TIME) {

	switch (bit) {

	case TRACE_GRAPH_SLEEP_TIME:

		if (set) {

			fgraph_no_sleep_time--;

			if (WARN_ON_ONCE(fgraph_no_sleep_time < 0))
@@ -1672,19 +1673,20 @@ func_graph_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set) 
		} else {

			fgraph_no_sleep_time++;

		}

	}

		break;



	if (bit == TRACE_GRAPH_PRINT_IRQS) {

	case TRACE_GRAPH_PRINT_IRQS:

		if (set)

			ftrace_graph_skip_irqs--;

		else

			ftrace_graph_skip_irqs++;

		if (WARN_ON_ONCE(ftrace_graph_skip_irqs < 0))

			ftrace_graph_skip_irqs = 0;

	}

		break;



	if (bit == TRACE_GRAPH_ARGS)

	case TRACE_GRAPH_ARGS:

		return ftrace_graph_trace_args(tr, set);

	}



	return 0;

}