Commit bc10916e authored by Denis Efremov's avatar Denis Efremov Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: prevent ->Ssid overflow in rtw_wx_set_scan() 



This code has a check to prevent read overflow but it needs another
check to prevent writing beyond the end of the ->Ssid[] array.

Fixes: 2b42bd58 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarDenis Efremov <denis.e.efremov@oracle.com>
Link: https://lore.kernel.org/r/20220518070052.108287-1-denis.e.efremov@oracle.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4d0cc9e0

drivers/staging/r8188eu/os_dep/ioctl_linux.c

+4 −2
Original line number Diff line number Diff line
@@ -1131,9 +1131,11 @@ static int rtw_wx_set_scan(struct net_device *dev, struct iw_request_info *a, 
						break;

					}

					sec_len = *(pos++); len -= 1;

					if (sec_len > 0 && sec_len <= len) {

					if (sec_len > 0 &&

					    sec_len <= len &&

					    sec_len <= 32) {

						ssid[ssid_index].SsidLength = sec_len;

						memcpy(ssid[ssid_index].Ssid, pos, ssid[ssid_index].SsidLength);

						memcpy(ssid[ssid_index].Ssid, pos, sec_len);

						ssid_index++;

					}

					pos += sec_len;