Commit bc337e8c authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

mptcp: pm: remove unused ret value to set flags 



The returned value is not used, it can then be dropped.

Reviewed-by: default avatarMat Martineau <martineau@kernel.org>
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250221-net-next-mptcp-pm-misc-cleanup-3-v1-1-2b70ab1cee79@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8f3f4464

net/mptcp/pm_netlink.c

+4 −6
Original line number Diff line number Diff line
@@ -1922,13 +1922,11 @@ static void mptcp_pm_nl_fullmesh(struct mptcp_sock *msk, 
	spin_unlock_bh(&msk->pm.lock);

}



static int mptcp_nl_set_flags(struct net *net,

			      struct mptcp_addr_info *addr,

static void mptcp_nl_set_flags(struct net *net, struct mptcp_addr_info *addr,

			       u8 bkup, u8 changed)

{

	long s_slot = 0, s_num = 0;

	struct mptcp_sock *msk;

	int ret = -EINVAL;



	while ((msk = mptcp_token_iter_next(net, &s_slot, &s_num)) != NULL) {

		struct sock *sk = (struct sock *)msk;
@@ -1938,7 +1936,7 @@ static int mptcp_nl_set_flags(struct net *net, 


		lock_sock(sk);

		if (changed & MPTCP_PM_ADDR_FLAG_BACKUP)

			ret = mptcp_pm_nl_mp_prio_send_ack(msk, addr, NULL, bkup);

			mptcp_pm_nl_mp_prio_send_ack(msk, addr, NULL, bkup);

		if (changed & MPTCP_PM_ADDR_FLAG_FULLMESH)

			mptcp_pm_nl_fullmesh(msk, addr);

		release_sock(sk);
@@ -1948,7 +1946,7 @@ static int mptcp_nl_set_flags(struct net *net, 
		cond_resched();

	}



	return ret;

	return;

}



int mptcp_pm_nl_set_flags(struct mptcp_pm_addr_entry *local,