Commit bc3a9254 authored by Michael Chan's avatar Michael Chan Committed by David S. Miller
Browse files

[TG3]: Add lower bound checks for tx ring size. 



The minimum tx ring size must be greater than MAX_SKB_FRAGS or 3
times that on some chips with TSO bugs.

Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 42952231

drivers/net/tg3.c

+4 −1
Original line number Diff line number Diff line
@@ -8106,7 +8106,10 @@ static int tg3_set_ringparam(struct net_device *dev, struct ethtool_ringparam *e 


	if ((ering->rx_pending > TG3_RX_RING_SIZE - 1) ||

	    (ering->rx_jumbo_pending > TG3_RX_JUMBO_RING_SIZE - 1) ||

	    (ering->tx_pending > TG3_TX_RING_SIZE - 1))

	    (ering->tx_pending > TG3_TX_RING_SIZE - 1) ||

	    (ering->tx_pending <= MAX_SKB_FRAGS) ||

	    ((tp->tg3_flags2 & TG3_FLG2_HW_TSO_1_BUG) &&

	     (ering->tx_pending <= (MAX_SKB_FRAGS * 3))))

		return -EINVAL;



	if (netif_running(dev)) {