Commit bc3cbc0c authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno Committed by Chun-Kuang Hu
Browse files

drm/mediatek: mtk_hdmi: Remove goto in mtk_hdmi_clk_enable_audio() 



If the clk_prepare_enable() call for the SPDIF clock fails, just
disable and unprepare the clock in the error check branch and
return immediately instead of jumping to the end with a goto,
slightly reducing code size.

This commit brings no functional changes.

Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20250217154836.108895-32-angelogioacchino.delregno@collabora.com/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent 900f5b37

drivers/gpu/drm/mediatek/mtk_hdmi.c

+4 −5
Original line number Diff line number Diff line
@@ -1159,15 +1159,14 @@ static int mtk_hdmi_clk_enable_audio(struct mtk_hdmi *hdmi) 
		return ret;



	ret = clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_AUD_SPDIF]);

	if (ret)

		goto err;



	return 0;

err:

	if (ret) {

		clk_disable_unprepare(hdmi->clk[MTK_HDMI_CLK_AUD_BCLK]);

		return ret;

	}



	return 0;

}



static void mtk_hdmi_clk_disable_audio(struct mtk_hdmi *hdmi)

{

	clk_disable_unprepare(hdmi->clk[MTK_HDMI_CLK_AUD_BCLK]);