Commit bc3f2b42 authored by Ewan D. Milne's avatar Ewan D. Milne Committed by Martin K. Petersen
Browse files

scsi: scsi_dh_alua: Remove check for ASC 24h in alua_rtpg() 

Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the
RTPG extended header so remove the check for INVALID FIELD IN CDB.

Link: https://lore.kernel.org/r/20210331201154.20348-1-emilne@redhat.com


Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarEwan D. Milne <emilne@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 22ec513e

drivers/scsi/device_handler/scsi_dh_alua.c

+3 −2
Original line number Diff line number Diff line
@@ -579,10 +579,11 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg) 
		 * even though it shouldn't according to T10.

		 * The retry without rtpg_ext_hdr_req set

		 * handles this.

		 * Note:  some arrays return a sense key of ILLEGAL_REQUEST

		 * with ASC 00h if they don't support the extended header.

		 */

		if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) &&

		    sense_hdr.sense_key == ILLEGAL_REQUEST &&

		    sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {

		    sense_hdr.sense_key == ILLEGAL_REQUEST) {

			pg->flags |= ALUA_RTPG_EXT_HDR_UNSUPP;

			goto retry;

		}