Commit bc4c0a48 authored by Wake Liu's avatar Wake Liu Committed by Jakub Kicinski
Browse files

selftests/net: Ensure assert() triggers in psock_tpacket.c



The get_next_frame() function in psock_tpacket.c was missing a return
statement in its default switch case, leading to a compiler warning.

This was caused by a `bug_on(1)` call, which is defined as an
`assert()`, being compiled out because NDEBUG is defined during the
build.

Instead of adding a `return NULL;` which would silently hide the error
and could lead to crashes later, this change restores the original
author's intent. By adding `#undef NDEBUG` before including <assert.h>,
we ensure the assertion is active and will cause the test to abort if
this unreachable code is ever executed.

Signed-off-by: default avatarWake Liu <wakel@google.com>
Link: https://patch.msgid.link/20250809062013.2407822-1-wakel@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c36748e8
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@
 *   - TPACKET_V3: RX_RING
 */

#undef NDEBUG
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>