Commit bc74d329 authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Jakub Kicinski
Browse files

netlink: Remove the dead code in netlink_proto_init() 



In the error path of netlink_proto_init(), frees the already allocated
bucket table for new hash tables in a loop, but it is going to panic,
so it is not necessary to clean up the resources, just remove the
dead code.

Suggested-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Link: https://patch.msgid.link/20241030012147.357400-1-ruanjinjie@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d3774a4b

net/netlink/af_netlink.c

+1 −5
Original line number Diff line number Diff line
@@ -2935,13 +2935,9 @@ static int __init netlink_proto_init(void) 


	for (i = 0; i < MAX_LINKS; i++) {

		if (rhashtable_init(&nl_table[i].hash,

				    &netlink_rhashtable_params) < 0) {

			while (--i > 0)

				rhashtable_destroy(&nl_table[i].hash);

			kfree(nl_table);

				    &netlink_rhashtable_params) < 0)

			goto panic;

	}

	}



	netlink_add_usersock_entry();