Commit bc76f575 authored by Mario Limonciello's avatar Mario Limonciello
Browse files

cpufreq: amd-pstate: Don't create attributes when registration fails 



If driver registration fails then immediately return the failure
instead of continuing to register attributes.

This fixes issues of falling back from amd-pstate to other drivers
when cpufreq init has failed for any reason.

Reported-by: default avatar <alex.s.cochran@proton.me>
Reviewed-by: default avatarGautham R. Shenoy <gautham.shenoy@amd.com>
Reviewed-by: default avatarPerry Yuan <Perry.Yuan@amd.com>
Link: https://lore.kernel.org/r/20240623200918.52104-1-mario.limonciello@amd.com


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
parent e1a921f7

drivers/cpufreq/amd-pstate.c

+5 −1
Original line number Diff line number Diff line
@@ -1863,8 +1863,10 @@ static int __init amd_pstate_init(void) 
	}



	ret = cpufreq_register_driver(current_pstate_driver);

	if (ret)

	if (ret) {

		pr_err("failed to register with return %d\n", ret);

		goto disable_driver;

	}



	dev_root = bus_get_dev_root(&cpu_subsys);

	if (dev_root) {
@@ -1880,6 +1882,8 @@ static int __init amd_pstate_init(void) 


global_attr_free:

	cpufreq_unregister_driver(current_pstate_driver);

disable_driver:

	amd_pstate_enable(false);

	return ret;

}

device_initcall(amd_pstate_init);