Commit bc88d44b authored by Steven Price's avatar Steven Price Committed by Thomas Gleixner
Browse files

irqchip/gic-v3-its: Fix over allocation in itt_alloc_pool() 



itt_alloc_pool() calls its_alloc_pages_node() to allocate an individual
page to add to the pool (for allocations <PAGE_SIZE). However the final
argument of its_alloc_pages_node() is the page order not the number of
pages. Currently it allocates two pages and leaks the second page.
Fix it by passing 0 instead (1 << 0 = 1 page).

Fixes: b08e2f42 ("irqchip/gic-v3-its: Share ITS tables with a non-trusted hypervisor")
Reported-by: default avatarShanker Donthineni <sdonthineni@nvidia.com>
Signed-off-by: default avatarSteven Price <steven.price@arm.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/1f6e19c4-1fb9-43ab-a8a2-a465c9cff84b@arm.com
Closes: https://lore.kernel.org/r/ed65312a-245c-4fa5-91ad-5d620cab7c6b%40nvidia.com
parent 010863f4

drivers/irqchip/irq-gic-v3-its.c

+1 −1
Original line number Diff line number Diff line
@@ -261,7 +261,7 @@ static void *itt_alloc_pool(int node, int size) 
		if (addr)

			break;



		page = its_alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 1);

		page = its_alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 0);

		if (!page)

			break;