Commit bc9847c9 authored by Jai Luthra's avatar Jai Luthra Committed by Vinod Koul
Browse files

dmaengine: ti: k3-udma: Report short packet errors 



Propagate the TR response status to the device using BCDMA
split-channels. For example CSI-RX driver should be able to check if a
frame was not transferred completely (short packet) and needs to be
discarded.

Fixes: 25dcb5dd ("dmaengine: ti: New driver for K3 UDMA")
Signed-off-by: default avatarJai Luthra <j-luthra@ti.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20240103-tr_resp_err-v1-1-2fdf6d48ab92@ti.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6e227620

drivers/dma/ti/k3-udma.c

+8 −2
Original line number Diff line number Diff line
@@ -3968,6 +3968,7 @@ static void udma_desc_pre_callback(struct virt_dma_chan *vc, 
{

	struct udma_chan *uc = to_udma_chan(&vc->chan);

	struct udma_desc *d;

	u8 status;



	if (!vd)

		return;
@@ -3977,12 +3978,12 @@ static void udma_desc_pre_callback(struct virt_dma_chan *vc, 
	if (d->metadata_size)

		udma_fetch_epib(uc, d);



	/* Provide residue information for the client */

	if (result) {

		void *desc_vaddr = udma_curr_cppi5_desc_vaddr(d, d->desc_idx);



		if (cppi5_desc_get_type(desc_vaddr) ==

		    CPPI5_INFO0_DESC_TYPE_VAL_HOST) {

			/* Provide residue information for the client */

			result->residue = d->residue -

					  cppi5_hdesc_get_pktlen(desc_vaddr);

			if (result->residue)
@@ -3991,6 +3992,11 @@ static void udma_desc_pre_callback(struct virt_dma_chan *vc, 
				result->result = DMA_TRANS_NOERROR;

		} else {

			result->residue = 0;

			/* Propagate TR Response errors to the client */

			status = d->hwdesc[0].tr_resp_base->status;

			if (status)

				result->result = DMA_TRANS_ABORTED;

			else

				result->result = DMA_TRANS_NOERROR;

		}

	}