Commit bca06573 authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: tegra: xusb: fix device and OF node leak at probe 



Make sure to drop the references taken to the PMC OF node and device by
of_parse_phandle() and of_find_device_by_node() during probe.

Note the holding a reference to the PMC device does not prevent the
PMC regmap from going away (e.g. if the PMC driver is unbound) so there
is no need to keep the reference.

Fixes: 2d102148 ("phy: tegra: xusb: Add wake/sleepwalk for Tegra210")
Cc: stable@vger.kernel.org	# 5.14
Cc: JC Kuo <jckuo@nvidia.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250724131206.2211-2-johan@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 5cfdfc62

drivers/phy/tegra/xusb-tegra210.c

+5 −1
Original line number Diff line number Diff line
@@ -3164,18 +3164,22 @@ tegra210_xusb_padctl_probe(struct device *dev, 
	}



	pdev = of_find_device_by_node(np);

	of_node_put(np);

	if (!pdev) {

		dev_warn(dev, "PMC device is not available\n");

		goto out;

	}



	if (!platform_get_drvdata(pdev))

	if (!platform_get_drvdata(pdev)) {

		put_device(&pdev->dev);

		return ERR_PTR(-EPROBE_DEFER);

	}



	padctl->regmap = dev_get_regmap(&pdev->dev, "usb_sleepwalk");

	if (!padctl->regmap)

		dev_info(dev, "failed to find PMC regmap\n");



	put_device(&pdev->dev);

out:

	return &padctl->base;

}