Commit bcb4a5c6 authored by Alex Hung's avatar Alex Hung Committed by Alex Deucher
Browse files

drm/amd/display: Remove redundant assignments 



[WHAT & HOW]
log2_blk_height and log2_blk_width are assigned to 0 and then
immediately are updated to other values. The assignments to zero are
redudant and removed.

This fixes 18 UNUSED_VALUE issues reported by Coverity.

Reviewed-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b9c8ad73

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c

+0 −4
Original line number Diff line number Diff line
@@ -443,8 +443,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib, 
	blk_bytes = surf_linear ?

			256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);

	log2_blk_bytes = dml_log2((double) blk_bytes);

	log2_blk_height = 0;

	log2_blk_width = 0;



	// remember log rule

	// "+" in log is multiply
@@ -491,8 +489,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib, 
			- log2_meta_req_height;

	meta_req_width = 1 << log2_meta_req_width;

	meta_req_height = 1 << log2_meta_req_height;

	log2_meta_row_height = 0;

	meta_row_width_ub = 0;



	// the dimensions of a meta row are meta_row_width x meta_row_height in elements.

	// calculate upper bound of the meta_row_width

drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20v2.c

+0 −4
Original line number Diff line number Diff line
@@ -443,8 +443,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib, 
	blk_bytes = surf_linear ?

			256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);

	log2_blk_bytes = dml_log2((double) blk_bytes);

	log2_blk_height = 0;

	log2_blk_width = 0;



	// remember log rule

	// "+" in log is multiply
@@ -491,8 +489,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib, 
			- log2_meta_req_height;

	meta_req_width = 1 << log2_meta_req_width;

	meta_req_height = 1 << log2_meta_req_height;

	log2_meta_row_height = 0;

	meta_row_width_ub = 0;



	// the dimensions of a meta row are meta_row_width x meta_row_height in elements.

	// calculate upper bound of the meta_row_width

drivers/gpu/drm/amd/display/dc/dml/dcn21/display_rq_dlg_calc_21.c

+0 −4
Original line number Diff line number Diff line
@@ -435,8 +435,6 @@ static void get_meta_and_pte_attr( 
	blk_bytes = surf_linear ?

			256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);

	log2_blk_bytes = dml_log2((double) blk_bytes);

	log2_blk_height = 0;

	log2_blk_width = 0;



	// remember log rule

	// "+" in log is multiply
@@ -485,8 +483,6 @@ static void get_meta_and_pte_attr( 
			- log2_meta_req_height;

	meta_req_width = 1 << log2_meta_req_width;

	meta_req_height = 1 << log2_meta_req_height;

	log2_meta_row_height = 0;

	meta_row_width_ub = 0;



	// the dimensions of a meta row are meta_row_width x meta_row_height in elements.

	// calculate upper bound of the meta_row_width

drivers/gpu/drm/amd/display/dc/dml/dcn30/display_rq_dlg_calc_30.c

+0 −4
Original line number Diff line number Diff line
@@ -392,8 +392,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib, 
	blk_bytes = surf_linear ?

		256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);

	log2_blk_bytes = dml_log2((double)blk_bytes);

	log2_blk_height = 0;

	log2_blk_width = 0;



	// remember log rule

	// "+" in log is multiply
@@ -464,8 +462,6 @@ static void get_meta_and_pte_attr(struct display_mode_lib *mode_lib, 
		- log2_meta_req_height;

	meta_req_width = 1 << log2_meta_req_width;

	meta_req_height = 1 << log2_meta_req_height;

	log2_meta_row_height = 0;

	meta_row_width_ub = 0;



	// the dimensions of a meta row are meta_row_width x meta_row_height in elements.

	// calculate upper bound of the meta_row_width

drivers/gpu/drm/amd/display/dc/dml/dcn31/display_rq_dlg_calc_31.c

+0 −4
Original line number Diff line number Diff line
@@ -413,8 +413,6 @@ static void get_meta_and_pte_attr( 
	log2_blk256_height = dml_log2((double) blk256_height);

	blk_bytes = surf_linear ? 256 : get_blk_size_bytes((enum source_macro_tile_size) macro_tile_size);

	log2_blk_bytes = dml_log2((double) blk_bytes);

	log2_blk_height = 0;

	log2_blk_width = 0;



	// remember log rule

	// "+" in log is multiply
@@ -481,8 +479,6 @@ static void get_meta_and_pte_attr( 
	log2_meta_req_width = log2_meta_req_bytes + 8 - log2_bytes_per_element - log2_meta_req_height;

	meta_req_width = 1 << log2_meta_req_width;

	meta_req_height = 1 << log2_meta_req_height;

	log2_meta_row_height = 0;

	meta_row_width_ub = 0;



	// the dimensions of a meta row are meta_row_width x meta_row_height in elements.

	// calculate upper bound of the meta_row_width