Commit bcdcb115 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Richard Weinberger
Browse files

ubifs: Fix uninitialized use of err in ubifs_jnl_write_inode() 



Clang warns (or errors with CONFIG_WERROR=y):

  fs/ubifs/journal.c:986:20: error: variable 'err' is uninitialized when used here [-Werror,-Wuninitialized]
    986 |                 ubifs_ro_mode(c, err);
        |                                  ^~~

Set err to -EPERM before the call to ubifs_ro_mode() and reuse it in the
return statement to resolve the warning.

Fixes: 957e1c4e ("ubifs: ubifs_jnl_write_inode: Only check once for the limitation of xattr count")
Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent fe051552

fs/ubifs/journal.c

+2 −1
Original line number Diff line number Diff line
@@ -983,8 +983,9 @@ int ubifs_jnl_write_inode(struct ubifs_info *c, const struct inode *inode) 


	if (kill_xattrs && ui->xattr_cnt > ubifs_xattr_max_cnt(c)) {

		ubifs_err(c, "Cannot delete inode, it has too much xattrs!");

		err = -EPERM;

		ubifs_ro_mode(c, err);

		return -EPERM;

		return err;

	}



	/*