Unverified Commit bce84306 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

regmap: maple: Switch to use kmemdup_array() 



Let the kememdup_array() take care about multiplication and possible
overflows.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240606164717.3031107-5-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f755d695

drivers/base/regmap/regcache-maple.c

+6 −7
Original line number Diff line number Diff line
@@ -132,8 +132,8 @@ static int regcache_maple_drop(struct regmap *map, unsigned int min, 
			lower_index = mas.index;

			lower_last = min -1;



			lower = kmemdup(entry, ((min - mas.index) *

						sizeof(unsigned long)),

			lower = kmemdup_array(entry,

					      min - mas.index, sizeof(*lower),

					      map->alloc_flags);

			if (!lower) {

				ret = -ENOMEM;
@@ -145,9 +145,8 @@ static int regcache_maple_drop(struct regmap *map, unsigned int min, 
			upper_index = max + 1;

			upper_last = mas.last;



			upper = kmemdup(&entry[max - mas.index + 1],

					((mas.last - max) *

					 sizeof(unsigned long)),

			upper = kmemdup_array(&entry[max - mas.index + 1],

					      mas.last - max, sizeof(*upper),

					      map->alloc_flags);

			if (!upper) {

				ret = -ENOMEM;