Commit bce98bf7 authored by Stephen Boyd's avatar Stephen Boyd Committed by Rob Clark
Browse files

drm/msm: Use VERB() for extra verbose logging 



These messages are useful for bringup/early development but in
production they don't provide much value. We know what sort of GPU we
have and interrupt information can be gathered other ways. This cuts
down on lines in the drm debug logs that happen too often, making the
debug logs practically useless.

Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Abhinav Kumar <abhinavk@codeaurora.org>
Cc: Kuogee Hsieh <khsieh@codeaurora.org>
Cc: aravindh@codeaurora.org
Cc: Sean Paul <sean@poorly.run>
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20210430193104.1770538-3-swboyd@chromium.org


[resolve merge conflicts with dpu irq refactor]
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent f591dbb5

drivers/gpu/drm/msm/adreno/adreno_gpu.c

+1 −1
Original line number Diff line number Diff line
@@ -408,7 +408,7 @@ int adreno_hw_init(struct msm_gpu *gpu) 
	struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);

	int ret, i;



	DBG("%s", gpu->name);

	VERB("%s", gpu->name);



	ret = adreno_load_fw(adreno_gpu);

	if (ret)

drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c

+4 −4
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ static void dpu_core_irq_callback_handler(void *arg, int irq_idx) 
	struct dpu_irq_callback *cb;

	unsigned long irq_flags;



	pr_debug("irq_idx=%d\n", irq_idx);

	VERB("irq_idx=%d\n", irq_idx);



	if (list_empty(&irq_obj->irq_cb_tbl[irq_idx]))

		DRM_ERROR("no registered cb, idx:%d\n", irq_idx);
@@ -80,7 +80,7 @@ int dpu_core_irq_register_callback(struct dpu_kms *dpu_kms, int irq_idx, 
		return -EINVAL;

	}



	DPU_DEBUG("[%pS] irq_idx=%d\n", __builtin_return_address(0), irq_idx);

	VERB("[%pS] irq_idx=%d\n", __builtin_return_address(0), irq_idx);



	spin_lock_irqsave(&dpu_kms->irq_obj.cb_lock, irq_flags);

	trace_dpu_core_irq_register_callback(irq_idx, register_irq_cb);
@@ -125,7 +125,7 @@ int dpu_core_irq_unregister_callback(struct dpu_kms *dpu_kms, int irq_idx, 
		return -EINVAL;

	}



	DPU_DEBUG("[%pS] irq_idx=%d\n", __builtin_return_address(0), irq_idx);

	VERB("[%pS] irq_idx=%d\n", __builtin_return_address(0), irq_idx);



	spin_lock_irqsave(&dpu_kms->irq_obj.cb_lock, irq_flags);

	trace_dpu_core_irq_unregister_callback(irq_idx, register_irq_cb);
@@ -138,7 +138,7 @@ int dpu_core_irq_unregister_callback(struct dpu_kms *dpu_kms, int irq_idx, 
		if (ret)

			DPU_ERROR("Fail to disable IRQ for irq_idx:%d\n",

					irq_idx);

		DPU_DEBUG("irq_idx=%d ret=%d\n", irq_idx, ret);

		VERB("irq_idx=%d ret=%d\n", irq_idx, ret);

	}

	spin_unlock_irqrestore(&dpu_kms->irq_obj.cb_lock, irq_flags);